[Fleet] Ensure policies are not out of sync #175065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
commented
Jan 18, 2024
|
|
||
| if (outdatedAgentPolicyIds.length) { | ||
| await agentPolicyService.deployPolicies(soClient, outdatedAgentPolicyIds).catch((error) => { | ||
| logger.warn(`Error deploying policies: ${error.message}`, { error }); |
There was a problem hiding this comment.
I think there is no need to crash the setup if this fail, it's why I am swallowing the error here
There was a problem hiding this comment.
nit: could we add a unit test for the error scenario? I usually combine async-await with try-catch, I suppose it should work with catch too.
kpollich
approved these changes
Jan 18, 2024
| // be a bottleneck in environments with several thousand agent policies being deployed here. | ||
| (agentPolicyId) => agentPolicyService.getFullAgentPolicy(soClient, agentPolicyId), | ||
| { | ||
| concurrency: 50, |
|
/ci |
juliaElastic
approved these changes
Jan 18, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
added
v8.13.0
backport:skip
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to https://github.com/elastic/ingest-dev/issues/2120
Re-introduce
ensureFleetServerAgentPoliciesExistsdeleted (by mistake I think) in #121628 .I made some refacto to avoid retrieving multiple time policies to both verify enrollement token and
.fleet-policiesTests
I added some unit test to cover that, you can manually test that by deleting document in
.fleet-policiesand verifying that the policy is created again on next setupFor example in the devtools
